Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export both now and random functions #389

Merged
merged 1 commit into from
May 23, 2021

Conversation

jimexist
Copy link
Member

Which issue does this PR close?

related to #374

Rationale for this change

export now and random functions

What changes are included in this PR?

Are there any user-facing changes?

Copy link
Member

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yap, we missed these 👍 Good to go.

@codecov-commenter
Copy link

Codecov Report

Merging #389 (22a3804) into master (db4f098) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   74.94%   74.94%           
=======================================
  Files         146      146           
  Lines       24314    24314           
=======================================
  Hits        18221    18221           
  Misses       6093     6093           
Impacted Files Coverage Δ
datafusion/src/logical_plan/expr.rs 84.34% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4f098...22a3804. Read the comment docs.

@jimexist jimexist changed the title export both now and random functions export both now and random functions May 23, 2021
@alamb alamb added the datafusion Changes in the datafusion crate label May 23, 2021
@alamb alamb merged commit 174226c into apache:master May 23, 2021
@alamb
Copy link
Contributor

alamb commented May 23, 2021

Thanks @jimexist

@jimexist jimexist deleted the export-now-random branch May 25, 2021 12:56
@houqp houqp added the enhancement New feature or request label Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants